Improve syntax highlighting colors for dark theme in MANIFEST.MF #1504
Conversation
|
cc @BeckerWdf and @mvm-sap WDYT? |
Test Results12 files - 273 12 suites - 273 6s ⏱️ - 50m 26s Results for commit 1372671. ± Comparison against base commit b8ce236. This pull request removes 3560 tests.♻️ This comment has been updated with latest results. |
vogella
force-pushed
the
manifest-syntax-highlighting
branch
from
c2c3e3a to
c368ad8
Compare
Yes, keywords look sharper and clearer now than in the old ones. Looks good to me. |
Changing the color to the same as for classes in the Java editor and removing the bold setting. Fixes eclipse-pde#1503
vogella
force-pushed
the
manifest-syntax-highlighting
branch
from
c368ad8 to
1372671
Compare
|
@BeckerWdf you made a comment in the forked repo. Please add it here. |
Yes. I noticed it also. See comments here. |
| 'editor.color.header_key=221,40,103' | ||
| 'editor.color.header_key_bold=true' | ||
| 'editor.color.header_osgi=38,139,210' | ||
| 'editor.color.header_key=18,144,195' |
There was a problem hiding this comment.
So you are changing from red-ish to blue-ish?
There was a problem hiding this comment.
@BeckerWdf Tbh I changed it during testing and later I forgot about it as I did not find a key in the manifest which uses it. Are you aware of such a key? I can change it back for this key if desired just to be save.
|
@vogella for style changes please always give before/after screenshot and provide dark/light mode examples if changing especially for darkmode. |
Changing the color to the same as for classes in the Java editor and removing the bold setting.
Fixes #1503